From e8ab8993949e960af931f24913d32a5c023bab97 Mon Sep 17 00:00:00 2001 From: Tyler Hoang Date: Tue, 19 May 2026 00:52:16 -0700 Subject: fix: resolve quality review issues in PriceVsValueCard - Add 150ms ease transitions to pvv-fill and pvv-tick (design system) - Move fill color to modifier CSS classes, drop inline background/opacity - Guard iv === 0 to prevent Infinity in premium/discount label - Remove ambiguous direction arrows from IV figure - Add "projection" suffix to year count in assumption summary Co-Authored-By: Claude Sonnet 4.6 --- frontend/app/prism-shell.css | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'frontend/app/prism-shell.css') diff --git a/frontend/app/prism-shell.css b/frontend/app/prism-shell.css index 9bcbdc5..09b8ebd 100644 --- a/frontend/app/prism-shell.css +++ b/frontend/app/prism-shell.css @@ -1924,14 +1924,19 @@ top: 0; height: 100%; border-radius: var(--r-full); + transition: left 150ms ease, width 150ms ease; } +.psm-pvv-fill--premium { background: var(--negative); opacity: 0.5; } +.psm-pvv-fill--discount { background: var(--positive); opacity: 0.5; } + .psm-pvv-tick { position: absolute; top: -4px; width: 2px; height: 12px; border-radius: 1px; + transition: left 150ms ease; } .psm-pvv-tick.price { -- cgit v1.3-2-g0d8e