From 6b8e9470d5b40030172b0413f0c5875fcbe65595 Mon Sep 17 00:00:00 2001 From: Tyler Hoang Date: Sun, 17 May 2026 13:20:12 -0700 Subject: Fix design system violations and logic bugs from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove backdrop-filter blur (glass effect) from TopBar; use opaque ink-1 background - Remove decorative glow box-shadows from market status dot - Fix button border-radius: var(--r-2) โ†’ var(--r-1) (4px โ†’ 2px) per design rules - Replace invented hover color rgba(194,170,122,0.04) with var(--ink-3) token - Add missing .psm-signal.neu CSS rule so neutral signals have visual treatment - Use HTML disabled attribute on nav buttons instead of aria-disabled alone - Replace duplicate EPS KPI tile with Prev Close to remove redundancy with P/E sublabel - Rename sortIndices โ†’ limitIndices (function only truncates, never sorts) Co-Authored-By: Claude Sonnet 4.6 --- frontend/lib/overview.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'frontend/lib/overview.ts') diff --git a/frontend/lib/overview.ts b/frontend/lib/overview.ts index db30050..efbd9f9 100644 --- a/frontend/lib/overview.ts +++ b/frontend/lib/overview.ts @@ -45,10 +45,10 @@ export function buildKpis(overview: TickerOverview): KpiItem[] { missing: overview.stats.trailing_pe == null }, { - key: "EPS ยท TTM", - value: fmtCurrency(overview.stats.trailing_eps), - sublabel: `Prev close ${fmtCurrency(overview.quote.prev_close)}`, - missing: overview.stats.trailing_eps == null + key: "Prev Close", + value: fmtCurrency(overview.quote.prev_close), + sublabel: `Day chg ${fmtCurrency(overview.quote.change)}`, + missing: overview.quote.prev_close == null }, { key: "52W Position", @@ -105,7 +105,7 @@ export function watchlistSubtitle(item: WatchlistItem): string { }); } -export function sortIndices(indices: MarketIndex[]): MarketIndex[] { +export function limitIndices(indices: MarketIndex[]): MarketIndex[] { return [...indices].slice(0, 4); } -- cgit v1.3-2-g0d8e